Fix Next/Prev enable state (#407) and unbind Cyan shortcut by default…#408
Merged
Conversation
…#406) #407: the toolbar's Next/Prev enable check ran in raw uploaded_files (load-order) index space while navigation walks the sidebar's sorted/ filtered display order. On rolls not loaded alphabetically the two disagree: Next greys out on the last-loaded frame (mid-list) and stays enabled-but-no-op on the display-last frame. Compute enable state in display space via asset_model.actual_to_display, matching next_file/ prev_file, and refresh on asset_model.layoutChanged (sort/filter changes emit that, not state_changed). #406: ship Cyan (cyan_inc/cyan_dec) with empty default bindings. Empty keys are already handled end-to-end (apply_bindings and the editor's duplicate check skip them), so Cyan is unbound out of the box yet stays assignable via the shortcut editor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (#406)
#407: the toolbar's Next/Prev enable check ran in raw uploaded_files (load-order) index space while navigation walks the sidebar's sorted/ filtered display order. On rolls not loaded alphabetically the two disagree: Next greys out on the last-loaded frame (mid-list) and stays enabled-but-no-op on the display-last frame. Compute enable state in display space via asset_model.actual_to_display, matching next_file/ prev_file, and refresh on asset_model.layoutChanged (sort/filter changes emit that, not state_changed).
#406: ship Cyan (cyan_inc/cyan_dec) with empty default bindings. Empty keys are already handled end-to-end (apply_bindings and the editor's duplicate check skip them), so Cyan is unbound out of the box yet stays assignable via the shortcut editor.